Skip to content

Don't exclude default product test config on non-fork PRs#13190

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
nineinchnick:default-pt-config-non-fork
Jul 15, 2022
Merged

Don't exclude default product test config on non-fork PRs#13190
ebyhr merged 1 commit intotrinodb:masterfrom
nineinchnick:default-pt-config-non-fork

Conversation

@nineinchnick
Copy link
Member

Description

We noticed that in #13183 the suite-delta-lake-databricks job didn't run and it's because PRs without tests:* labels exclude the default config. This allows this config to be used in PRs created by maintainers in the trino repository, not in forks. It'll run even more product tests, but such PRs are mostly used to test some changes with all secrets, that is the most possible coverage.

Is this change a fix, improvement, new feature, refactoring, or other?
improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
CI product tests

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@ebyhr ebyhr merged commit 0104c20 into trinodb:master Jul 15, 2022
@ebyhr
Copy link
Member

ebyhr commented Jul 15, 2022

Merged, thanks!

@github-actions github-actions bot added this to the 391 milestone Jul 15, 2022
@nineinchnick nineinchnick deleted the default-pt-config-non-fork branch July 15, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants