Skip to content

Enable impact analysis for product tests only on PRs#13191

Merged
losipiuk merged 1 commit intotrinodb:masterfrom
nineinchnick:disable-impact-analysis-on-master
Jul 15, 2022
Merged

Enable impact analysis for product tests only on PRs#13191
losipiuk merged 1 commit intotrinodb:masterfrom
nineinchnick:disable-impact-analysis-on-master

Conversation

@nineinchnick
Copy link
Member

Description

Impact analysis for product tests is enabled on the master branch, where all tests should always run. This happens even if GIB is disabled, because we make sure the gib-impacted.log file always exists, even on the master branch. An empty list of impacted modules is processed by the plugin reader and produces an empty list of impacted plugins, causing most product tests to be skipped.

This PR explicitly enabled impact analysis only on PRs in forks.

Is this change a fix, improvement, new feature, refactoring, or other?
fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
CI product tests

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jul 15, 2022
@nineinchnick nineinchnick requested review from kokosing and wendigo July 15, 2022 08:21
@nineinchnick nineinchnick force-pushed the disable-impact-analysis-on-master branch from ebd3257 to 9762d63 Compare July 15, 2022 08:21
@nineinchnick nineinchnick force-pushed the disable-impact-analysis-on-master branch from 9762d63 to ac18316 Compare July 15, 2022 10:17
@losipiuk losipiuk merged commit 54ee9dd into trinodb:master Jul 15, 2022
@github-actions github-actions bot added this to the 391 milestone Jul 15, 2022
@nineinchnick nineinchnick deleted the disable-impact-analysis-on-master branch July 25, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants