Enable impact analysis for product tests only on PRs#13191
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Jul 15, 2022
Merged
Enable impact analysis for product tests only on PRs#13191losipiuk merged 1 commit intotrinodb:masterfrom
losipiuk merged 1 commit intotrinodb:masterfrom
Conversation
ebd3257 to
9762d63
Compare
losipiuk
reviewed
Jul 15, 2022
9762d63 to
ac18316
Compare
losipiuk
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Impact analysis for product tests is enabled on the master branch, where all tests should always run. This happens even if GIB is disabled, because we make sure the
gib-impacted.logfile always exists, even on the master branch. An empty list of impacted modules is processed by the plugin reader and produces an empty list of impacted plugins, causing most product tests to be skipped.This PR explicitly enabled impact analysis only on PRs in forks.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: