Improve DictionaryBlock#getLogicalSizeInBytes#13203
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Jul 18, 2022
Merged
Improve DictionaryBlock#getLogicalSizeInBytes#13203raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
When fixedSizeInBytesPerPosition is known, it can be used to compute logical size of DictionaryBlock cheaply. Logical size for page is computed frequently by orc/parquet writers.
raunaqmorarka
force-pushed
the
dict-logical-size
branch
from
c075690 to
1ed0152
Compare
assaf2
reviewed
Jul 17, 2022
skrzypo987
approved these changes
Jul 18, 2022
assaf2
approved these changes
Jul 18, 2022
sopel39
approved these changes
Jul 18, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When fixedSizeInBytesPerPosition is known, it can be
used to compute logical size of DictionaryBlock cheaply.
Logical size for page is computed frequently by orc/parquet writers.
improvement
core query engine
Improved write performance when the writer works on dictionary encoded data.
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: