Fix Phoenix connector compilation in IntelliJ#13227
Merged
findepi merged 1 commit intotrinodb:masterfrom Jul 20, 2022
Merged
Conversation
IntelliJ doesn't seem to support multi-module projects when a module being dependent on is built with shading. As a workaround, add original dependency to compile-time classpath, but exclude it from final build. This let's IntelliJ compile the project, while still keeping the patched & shaded library as the runtime dependency. Alternatively we could move `trino-phoenix5-patched` module to a separate repo. Not doing this in hope this is a temporary workaround only.
Member
Author
|
This seems to fix the compilation. |
Member
Yeah, this is just a temporary workaround until the next release of Phoenix goes out. They said it would be fairly soon. |
Member
|
This IntelliJ shading limitation is why Hadoop and Hive shadings are in separate modules. |
homar
approved these changes
Jul 20, 2022
Member
Author
Correct
Correct, we're operating under the assumption this is temporary. |
ebyhr
approved these changes
Jul 20, 2022
hashhar
approved these changes
Jul 20, 2022
findepi
deleted the
findepi/fix-phoenix-connector-compilation-in-intellij-494adf
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntelliJ doesn't seem to support multi-module projects when a module
being dependent on is built with shading.
As a workaround, add original dependency to compile-time classpath, but
exclude it from final build. This let's IntelliJ compile the project,
while still keeping the patched & shaded library as the runtime
dependency.
Alternatively we could move
trino-phoenix5-patchedmodule to aseparate repo. Not doing this in hope this is a temporary workaround
only.