Add javadoc for ConnectorSplit#isRemotelyAccessible#13249
Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom Jul 21, 2022
Merged
Add javadoc for ConnectorSplit#isRemotelyAccessible#13249raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka merged 1 commit intotrinodb:masterfrom
Conversation
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorSplit.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorSplit.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
split-comment
branch
from
743f038 to
5aa6b00
Compare
Praveen2112
reviewed
Jul 20, 2022
core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorSplit.java
Outdated
Show resolved
Hide resolved
nineinchnick
approved these changes
Jul 20, 2022
raunaqmorarka
force-pushed
the
split-comment
branch
from
5aa6b00 to
ff91402
Compare
Praveen2112
approved these changes
Jul 20, 2022
martint
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: