Skip static functions when generating the bindings#101
Merged
JoshuaLampert merged 2 commits intotrixi-framework:mainfrom Nov 25, 2023
Merged
Skip static functions when generating the bindings#101JoshuaLampert merged 2 commits intotrixi-framework:mainfrom
JoshuaLampert merged 2 commits intotrixi-framework:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 16.25% 17.58% +1.33%
==========================================
Files 3 3
Lines 1538 1422 -116
==========================================
Hits 250 250
+ Misses 1288 1172 -116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sloede
reviewed
Nov 25, 2023
Member
sloede
left a comment
sloede
left a comment
There was a problem hiding this comment.
There's some weirdness in the changes to src/LibP4est.jl - maybe check it out (I marked only a few). Also, did you run any P4estMesh AMR test with Trixi.jl to verify that everything still works? Not sure if it is necessary, just wondering...
Member
Author
Yes, I just did. Everything works as expected with and without MPI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #99, calling static functions from P4est.jl is not possible. In Clang.jl v0.17.7, there exists the option to skip these static functions.