Format

[JoshuaLampert]

Maybe it's a good idea to also format P4est.jl. I excluded the wrapped file for now. I think most of it looks acceptable. What do you think, @sloede, @ranocha?

[sloede]

Maybe it's a good idea to also format P4est.jl. I excluded the wrapped file for now. I think most of it looks acceptable. What do you think, @sloede, @ranocha?

I think formatting is a good idea. I wouldn't format the wrapped file, since it is auto-generated, which makes it hard to compare it against changes once we have to re-generate it for some reason.

[JoshuaLampert]

I think formatting is a good idea. I wouldn't format the wrapped file, since it is auto-generated, which makes it hard to compare it against changes once we have to re-generate it for some reason.

I think so, too. We could in principle format the file at the end of the generator, but I would still advocate for not formatting the wrapped file.

[JoshuaLampert]

Again and again, we have a segfault when building the docs in CI. Do you know why?

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d25ad27) 17.64% compared to head (82ff687) 17.80%.

Files	Patch %	Lines
src/pointerwrappers.jl	92.59%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   17.64%   17.80%   +0.16%     
==========================================
  Files           3        3              
  Lines        1423     1427       +4     
==========================================
+ Hits          251      254       +3     
- Misses       1172     1173       +1     

Flag	Coverage Δ
unittests	17.80% <92.86%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ranocha]

I agree with what you have said above - good idea 👍

[ranocha]

Again and again, we have a segfault when building the docs in CI. Do you know why?

No idea, sorry. Looks like this has been happening for quite some time already...

[ranocha]

Thanks! I didn't check every line in the modified files but I think it should be fine

[JoshuaLampert]

Are you fine with merging, @sloede?

[sloede]

I only did a quick scan of the changes to test/, but nothing overly atrocious has caught my attention. LGTM, thanks!