Allow setproperty! for PointerWrappers with special structs#79
Merged
ranocha merged 3 commits intotrixi-framework:mainfrom Apr 16, 2023
Merged
Allow setproperty! for PointerWrappers with special structs#79ranocha merged 3 commits intotrixi-framework:mainfrom
setproperty! for PointerWrappers with special structs#79ranocha merged 3 commits intotrixi-framework:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 15.70% 15.90% +0.20%
==========================================
Files 3 3
Lines 1516 1516
==========================================
+ Hits 238 241 +3
+ Misses 1278 1275 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
sloede
requested changes
Apr 11, 2023
Member
sloede
left a comment
sloede
left a comment
There was a problem hiding this comment.
One small comment, otherwise this LGTM!
ranocha
requested changes
Apr 12, 2023
Member
ranocha
left a comment
ranocha
left a comment
There was a problem hiding this comment.
Thanks! Could you please add a test of the new functionality?
Member
Author
|
Do you think of an additional test than the ones I already added? If so, what kind of test were you thinking of? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #77 this adds the functionality to set properties also for structs as in #72 using the same approach like #74.