New Paired Explicit Runge-Kutta Integrator: Third Order#2008
Merged
ranocha merged 180 commits intotrixi-framework:mainfrom Nov 5, 2024
Merged
New Paired Explicit Runge-Kutta Integrator: Third Order#2008ranocha merged 180 commits intotrixi-framework:mainfrom
ranocha merged 180 commits intotrixi-framework:mainfrom
Conversation
…i.jl into PERK_p3_single_ext
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
DanielDoehring
requested changes
Nov 2, 2024
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
JoshuaLampert
previously approved these changes
Nov 2, 2024
Member
|
The CI error looks like it is caused by this PR: https://github.com/trixi-framework/Trixi.jl/actions/runs/11642978359/job/32423193644?pr=2008#step:7:1407 |
DanielDoehring
previously approved these changes
Nov 4, 2024
JoshuaLampert
previously approved these changes
Nov 4, 2024
ranocha
requested changes
Nov 5, 2024
Member
ranocha
left a comment
ranocha
left a comment
There was a problem hiding this comment.
Thanks - nearly ready to be merged 👍
src/time_integration/paired_explicit_runge_kutta/methods_PERK2.jl
Outdated
Show resolved
Hide resolved
src/time_integration/paired_explicit_runge_kutta/methods_PERK3.jl
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
November 5, 2024 11:34
Head branch was pushed to by a user without write access
warisa-r
dismissed stale reviews from DanielDoehring and JoshuaLampert
via
a872076
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new single-step paired explicit Runge-Kutta integrator of the third order. Along with this implementation, NLsolve has been added as a weak dependency.
Tests have been added for the example elixir_burgers_perk3.jl both with and without the fixed time step. Additionally,
methods_PERK2.jlis also modified so that some functions can also be called by the third-order integrator.Please feel free to let me know if there is anything that is missing or needs improvement!