Move subcell limiter func#2591
Merged
DanielDoehring merged 5 commits intotrixi-framework:mainfrom Oct 1, 2025
Merged
Conversation
Contributor
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2591 +/- ##
=======================================
Coverage 96.80% 96.80%
=======================================
Files 527 527
Lines 42609 42609
=======================================
Hits 41247 41247
Misses 1362 1362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bennibolm
reviewed
Oct 1, 2025
Co-authored-by: Benjamin Bolm <74359358+bennibolm@users.noreply.github.com>
bennibolm
previously approved these changes
Oct 1, 2025
bennibolm
reviewed
Oct 1, 2025
bennibolm
approved these changes
Oct 1, 2025
Contributor
|
@DanielDoehring Now, I'm happy. Maybe you can have one last look and we can merge it then. |
DanielDoehring
added a commit
to DanielDoehring/Trixi.jl
that referenced
this pull request
Feb 19, 2026
* move subcell limiter func * Update src/solvers/dgsem_tree/subcell_limiters.jl Co-authored-by: Benjamin Bolm <74359358+bennibolm@users.noreply.github.com> * Move `ContainerSubcellLimiterIDP` * Move functions --------- Co-authored-by: Benjamin Bolm <74359358+bennibolm@users.noreply.github.com> Co-authored-by: bennibolm <benjamin.bolm@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2588 (comment), #2587 (comment) and #2587 (comment)