Skip to content

Move subcell limiter func#2591

Merged
DanielDoehring merged 5 commits intotrixi-framework:mainfrom
DanielDoehring:MoveSubCellLimiter
Oct 1, 2025
Merged

Move subcell limiter func#2591
DanielDoehring merged 5 commits intotrixi-framework:mainfrom
DanielDoehring:MoveSubCellLimiter

Conversation

@DanielDoehring
Copy link
Copy Markdown
Member

@DanielDoehring DanielDoehring commented Oct 1, 2025

@DanielDoehring DanielDoehring added the refactoring Refactoring code without functional changes label Oct 1, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 1, 2025

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.80%. Comparing base (61ae744) to head (5b97d49).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2591   +/-   ##
=======================================
  Coverage   96.80%   96.80%           
=======================================
  Files         527      527           
  Lines       42609    42609           
=======================================
  Hits        41247    41247           
  Misses       1362     1362           
Flag Coverage Δ
unittests 96.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Benjamin Bolm <74359358+bennibolm@users.noreply.github.com>
bennibolm
bennibolm previously approved these changes Oct 1, 2025
@DanielDoehring DanielDoehring enabled auto-merge (squash) October 1, 2025 09:25
@bennibolm bennibolm disabled auto-merge October 1, 2025 11:44
@bennibolm
Copy link
Copy Markdown
Contributor

@DanielDoehring Now, I'm happy. Maybe you can have one last look and we can merge it then.

@DanielDoehring DanielDoehring merged commit 84303b9 into trixi-framework:main Oct 1, 2025
39 checks passed
@DanielDoehring DanielDoehring deleted the MoveSubCellLimiter branch October 1, 2025 14:03
DanielDoehring added a commit to DanielDoehring/Trixi.jl that referenced this pull request Feb 19, 2026
* move subcell limiter func

* Update src/solvers/dgsem_tree/subcell_limiters.jl

Co-authored-by: Benjamin Bolm <74359358+bennibolm@users.noreply.github.com>

* Move `ContainerSubcellLimiterIDP`

* Move functions

---------

Co-authored-by: Benjamin Bolm <74359358+bennibolm@users.noreply.github.com>
Co-authored-by: bennibolm <benjamin.bolm@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Refactoring code without functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants