Support for 3d idp mortars on TreeMesh#2626
Closed
bennibolm wants to merge 11 commits intotrixi-framework:bb/idp-amrfrom
Closed
Support for 3d idp mortars on TreeMesh#2626bennibolm wants to merge 11 commits intotrixi-framework:bb/idp-amrfrom
bennibolm wants to merge 11 commits intotrixi-framework:bb/idp-amrfrom
Conversation
Contributor
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## bb/idp-amr #2626 +/- ##
==============================================
- Coverage 96.84% 95.36% -1.47%
==============================================
Files 535 550 +15
Lines 43211 46335 +3124
==============================================
+ Hits 41844 44186 +2342
- Misses 1367 2149 +782
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cad2a93 to
934dd12
Compare
Adapt maximum allowed allocations Implement suggestions Apply changes to 3d code (remove `alpha1/2/3`) Reset antidiffusive fluxes after resizing in 3d Add empty line Fix bug Nicer line breaks Move funcs to p4est files Move even more Reduce allowed allocs in test Increase allocs number again Clean up elixir Add note to news.md Update news Implement suggestions Update src/callbacks_stage/subcell_limiter_idp_correction_3d.jl Remove `A4dp1_x/y/z` Use `maxthreadid()` Add full 3d implementation on P4estMesh Add `A5d` Add 3d TreeMesh implementation Adapt test
d81aa06 to
20903fe
Compare
55b4f56 to
98776c5
Compare
Contributor
Author
|
See bennibolm#145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also contains the implementation of subcell 3D from bennibolm#143 and 2D idp mortars from #2305.