Skip to content

DocPreviewCleanup should not error when no preview is found#488

Merged
ranocha merged 2 commits intomainfrom
hr/fix-DocPreviewCleanup
Mar 22, 2021
Merged

DocPreviewCleanup should not error when no preview is found#488
ranocha merged 2 commits intomainfrom
hr/fix-DocPreviewCleanup

Conversation

@ranocha
Copy link
Copy Markdown
Member

@ranocha ranocha commented Mar 22, 2021

As discussed on Slack.

@ranocha ranocha requested a review from sloede March 22, 2021 14:11
@ranocha ranocha enabled auto-merge (squash) March 22, 2021 14:12
sloede
sloede previously approved these changes Mar 22, 2021
Copy link
Copy Markdown
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this! If it works, should we also inform the people at Documenter about this fix?

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
@ranocha
Copy link
Copy Markdown
Member Author

ranocha commented Mar 22, 2021

If it works, should we also inform the people at Documenter about this fix?

Sounds reasonable to me (after testing this change). The relevant section in the docs of Documenter.jl is https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#gh-pages-Branch (source at https://github.com/JuliaDocs/Documenter.jl/blob/master/docs/src/man/hosting.md#gh-pages-branch). We might also consider amking a PR to some clima projects where similar scripts are used (e.g. https://github.com/CliMA/TimeMachine.jl/blob/master/.github/workflows/DocCleanup.yml)

@ranocha ranocha requested a review from sloede March 22, 2021 14:20
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 22, 2021

Codecov Report

Merging #488 (840a4f2) into main (d3421da) will not change coverage.
The diff coverage is n/a.

❗ Current head 840a4f2 differs from pull request most recent head a7445b5. Consider uploading reports for the commit a7445b5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #488   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files         103      103           
  Lines       11439    11439           
=======================================
  Hits        10838    10838           
  Misses        601      601           
Flag Coverage Δ
unittests 94.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3421da...a7445b5. Read the comment docs.

@ranocha ranocha merged commit 00e24fb into main Mar 22, 2021
@ranocha ranocha deleted the hr/fix-DocPreviewCleanup branch March 22, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants