DocPreviewCleanup should not error when no preview is found#488
DocPreviewCleanup should not error when no preview is found#488
Conversation
sloede
left a comment
There was a problem hiding this comment.
Thanks a lot for doing this! If it works, should we also inform the people at Documenter about this fix?
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Sounds reasonable to me (after testing this change). The relevant section in the docs of Documenter.jl is https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#gh-pages-Branch (source at https://github.com/JuliaDocs/Documenter.jl/blob/master/docs/src/man/hosting.md#gh-pages-branch). We might also consider amking a PR to some clima projects where similar scripts are used (e.g. https://github.com/CliMA/TimeMachine.jl/blob/master/.github/workflows/DocCleanup.yml) |
Codecov Report
@@ Coverage Diff @@
## main #488 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 103 103
Lines 11439 11439
=======================================
Hits 10838 10838
Misses 601 601
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
As discussed on Slack.