Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 87 87
Lines 4587 4587
=======================================
Hits 4556 4556
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is a note to self, the tutorial describing the setup of the Okushiri Tsunami would need changed to setup the boundary conditions as a |
Thanks for noting! I fixed that and adapted the remaining parts. I think this should be ready, but we need to wait until the breaking release of Trixi.jl is out to let CI run. |
andrewwinters5000
left a comment
There was a problem hiding this comment.
Thanks @JoshuaLampert ! This looks good from my side once everything on the Trixi.jl side is ready.
ranocha
left a comment
There was a problem hiding this comment.
LGTM. We will trigger CI once the Trixi.jl v0.15 has been released.
a1b7ddb
|
Thanks! |
This unifies the boundary conditions across mesh types, i.e.,
NamedTupleis used everywhere to pass boundary conditions, meshes are always non-periodic by default and boundary conditions have to be passed explicitly toSemidiscretizationHyperbolic. See trixi-framework/Trixi.jl#2761.