Skip to content

Unify boundary conditions#126

Merged
ranocha merged 9 commits intomainfrom
unify-bc
Feb 7, 2026
Merged

Unify boundary conditions#126
ranocha merged 9 commits intomainfrom
unify-bc

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert commented Jan 27, 2026

This unifies the boundary conditions across mesh types, i.e., NamedTuple is used everywhere to pass boundary conditions, meshes are always non-periodic by default and boundary conditions have to be passed explicitly to SemidiscretizationHyperbolic. See trixi-framework/Trixi.jl#2761.

@JoshuaLampert JoshuaLampert marked this pull request as draft January 27, 2026 16:14
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.32%. Comparing base (836423c) to head (0fa1318).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files          87       87           
  Lines        4587     4587           
=======================================
  Hits         4556     4556           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrewwinters5000
Copy link
Copy Markdown
Member

This is a note to self, the tutorial describing the setup of the Okushiri Tsunami would need changed to setup the boundary conditions as a NamedTuple rather than a Dict.

@JoshuaLampert
Copy link
Copy Markdown
Member Author

This is a note to self, the tutorial describing the setup of the Okushiri Tsunami would need changed to setup the boundary conditions as a NamedTuple rather than a Dict.

Thanks for noting! I fixed that and adapted the remaining parts. I think this should be ready, but we need to wait until the breaking release of Trixi.jl is out to let CI run.

Copy link
Copy Markdown
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JoshuaLampert ! This looks good from my side once everything on the Trixi.jl side is ready.

ranocha
ranocha previously approved these changes Feb 7, 2026
Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will trigger CI once the Trixi.jl v0.15 has been released.

@ranocha ranocha closed this Feb 7, 2026
@ranocha ranocha reopened this Feb 7, 2026
@ranocha ranocha marked this pull request as ready for review February 7, 2026 16:46
@ranocha ranocha enabled auto-merge (squash) February 7, 2026 16:47
@ranocha ranocha dismissed stale reviews from andrewwinters5000 and themself via a1b7ddb February 7, 2026 16:48
ranocha
ranocha previously approved these changes Feb 7, 2026
ranocha
ranocha previously approved these changes Feb 7, 2026
ranocha
ranocha previously approved these changes Feb 7, 2026
@ranocha ranocha enabled auto-merge (squash) February 7, 2026 17:13
@JoshuaLampert
Copy link
Copy Markdown
Member Author

JoshuaLampert commented Feb 7, 2026

Sorry, while debugging I found some old allocation tests, which I replaced with the new version from TrixiTest.jl in 24e8f02 and 0fa1318.

@ranocha ranocha merged commit 85924eb into main Feb 7, 2026
18 checks passed
@ranocha ranocha deleted the unify-bc branch February 7, 2026 18:02
@ranocha
Copy link
Copy Markdown
Member

ranocha commented Feb 7, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants