pr-approval-check: use separate workflow to check approvals #4530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
approved these changes
Nov 3, 2025
Contributor
mcastorina
left a comment
mcastorina
left a comment
There was a problem hiding this comment.
It would be nice to have some doc comments about how (and why) this works the way it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With this change, github actions triggers a separate workflow run that has the right permissions to check for approvals. This fixes an issue where pull request review events on PRs from forks didn't have the right credentials.
It's a little more complicated and takes a little longer, but this gets around the github actions design, as well as a bug in github actions with how the base and head repos are reported in the
pull_request_reviewevent.Checklist:
make test-community)?make lintthis requires golangci-lint)?