Fix the missing Ethon log info#124
Merged
Merged
Conversation
Owner
|
Hi @nulldef thanks for the PR, I never knew this was an issue. Could I bother you adding a test that fails before and passes after you fix? |
eb06413 to
f7fb05d
Compare
Contributor
Author
|
Hi @trusche The issue basically comes from the Typhoeus gem, it cleans up all the data right after the request is performed. https://github.com/typhoeus/typhoeus/blob/master/lib/typhoeus/easy_factory.rb#L171 So we don't have any data to log. |
Contributor
Author
|
HI @trusche! |
Owner
|
Sorry, missed that! Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently using the
httplogwithethon-based http lib we're getting a log with the missing URL in it.So we can memoize the URL in the
@http_logvariable and use it for logging.