Add deployment labels to workers#256
Merged
golfdish merged 4 commits intotryretool:mainfrom Oct 30, 2025
Merged
Conversation
Contributor
|
Looks fine to me, but could you say a little more about your use case (what is this fixing)? |
Contributor
Author
|
We're rolling out a new feature that will enforce labels on all our k8s resources, using Gatekeeper, making sure they're appropriately tagged (resource owner, environment, slack-channel, etc...) So I need to be able to label retool deployments |
golfdish
approved these changes
Oct 28, 2025
Contributor
Author
|
Thanks for the review! |
Contributor
I'll push the new chart version today after merging. |
Contributor
|
@T0RAT0RA the new release has been published! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I'd like to bring the
$.Values.deployment.labelsto the workers deployements, similare to the backend deployment: deployment_backend.yaml#L8-L10Thank you.