Skip to content

Fixed Speculative Generator#75

Merged
turboderp merged 1 commit intoturboderp-org:masterfrom
SinanAkkoyun:fix-speculative-gen
Sep 30, 2023
Merged

Fixed Speculative Generator#75
turboderp merged 1 commit intoturboderp-org:masterfrom
SinanAkkoyun:fix-speculative-gen

Conversation

@SinanAkkoyun
Copy link
Contributor

Hey! Just wanted to test the speculative.py example and noticed that the speculative generator did not use the (I suppose new) sampler syntax, so this is the fix for that. ^^

# from
token, prob = ExLlamaV2Sampler.sample(logits, draft_settings, past, randoms[i])

# to:
token, prob, _ = ExLlamaV2Sampler.sample(logits, draft_settings, past, randoms[i], self.tokenizer)

# etc :)

@turboderp
Copy link
Member

Yeah, for token healing the sampler needs to call the tokenizer. So I missed that.

@turboderp turboderp merged commit 90d29b0 into turboderp-org:master Sep 30, 2023
@SinanAkkoyun
Copy link
Contributor Author

I see, I'm so glad that you implemented speculative sampling as a nice generator, thank you!

@SinanAkkoyun SinanAkkoyun deleted the fix-speculative-gen branch October 2, 2023 18:36
anchortense pushed a commit to anchortense/exllamav2-logit-threshold-samplers that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants