Skip to content

Fix minor visual bug in Firefox caused by moz-focusring #32821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XhmikosR merged 5 commits into from
Feb 17, 2021
Merged

Fix minor visual bug in Firefox caused by moz-focusring #32821

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37ecbf8
Move moz-focusring into select.form-control
kremit Jan 17, 2021
de741a4
Update _forms.scss
XhmikosR Jan 26, 2021
bb9e72c
Merge branch 'v4-dev' into patch-1
XhmikosR Jan 27, 2021
6d74ecc
Merge branch 'v4-dev' into patch-1
XhmikosR Feb 12, 2021
f09018e
Merge branch 'v4-dev' into patch-1
XhmikosR Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions scss/_forms.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@
border: 0;
}

// Remove select outline from select box in FF
&:-moz-focusring {
color: transparent;
text-shadow: 0 0 0 $input-color;
}

// Customize the `:focus` state to imitate native WebKit styles.
@include form-control-focus($ignore-warning: true);

Expand Down Expand Up @@ -69,6 +63,12 @@ input[type="month"] {
}

select.form-control {
// Remove select outline from select box in FF
&:-moz-focusring {
color: transparent;
text-shadow: 0 0 0 $input-color;
}

&:focus::-ms-value {
// Suppress the nested default white text on blue background highlight given to
// the selected option text when the (still closed) <select> receives focus
Expand Down