Skip to content

Input group validation with custom-file input#33239

Merged
XhmikosR merged 6 commits intov4-devfrom
v4-dev-fod-validated-input-group-with-custom-file
Oct 21, 2021
Merged

Input group validation with custom-file input#33239
XhmikosR merged 6 commits intov4-devfrom
v4-dev-fod-validated-input-group-with-custom-file

Conversation

@ffoodd
Copy link
Copy Markdown
Contributor

@ffoodd ffoodd commented Mar 2, 2021

First try to fix #32867 — introduced with #31962.

Simple shot for now, not sure I totally understood what's been done — mostly the nth-last-child(n + 3) part, I'm certainly missing a test case to check this.


Previews:

@ffoodd ffoodd marked this pull request as ready for review March 2, 2021 11:18
@ffoodd ffoodd requested a review from a team as a code owner March 2, 2021 11:18
@XhmikosR XhmikosR requested a review from mdo May 1, 2021 13:53
@ffoodd
Copy link
Copy Markdown
Contributor Author

ffoodd commented Sep 1, 2021

Friendly ping @twbs/css-review :)

@XhmikosR
Copy link
Copy Markdown
Member

XhmikosR commented Oct 8, 2021

@mdo ping

@XhmikosR XhmikosR merged commit e482fbb into v4-dev Oct 21, 2021
@XhmikosR XhmikosR deleted the v4-dev-fod-validated-input-group-with-custom-file branch October 21, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants