Skip to content

Docs: Fix incorrect class name on migration guide #38883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julien-deramond merged 1 commit into from
Jul 10, 2023
Merged

Docs: Fix incorrect class name on migration guide #38883

julien-deramond merged 1 commit into from
Jul 10, 2023

Conversation

@coliff
Copy link
Contributor

@coliff coliff commented Jul 10, 2023 •
edited
Loading

Description

There wasn't a Bootstrap v4 class called .form-file - it was .form-control-file.

REF: https://getbootstrap.com/docs/4.6/dist/css/bootstrap.css

Motivation & Context

Help users upgrading by finding the right file in their code.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@coliff
Docs: Fix incorrect class name on migration guide
2009fd0 
There wasn't a class called `.form-file - it was `.form-control-file`.

REF: https://getbootstrap.com/docs/4.6/dist/css/bootstrap.css
@julien-deramond julien-deramond self-requested a review July 10, 2023 08:02
julien-deramond
julien-deramond approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coliff, good catch!

@julien-deramond julien-deramond merged commit 42a055c into twbs:main Jul 10, 2023
@coliff coliff deleted the patch-3 branch July 10, 2023 08:15
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@coliff @romankupchak93
Docs: Fix incorrect .form-file on migration guide (twbs#38883)
f0df717
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
This was referenced May 19, 2024
Open
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@Cpano Cpano mentioned this pull request May 24, 2024
Open
@zxcv32 zxcv32 mentioned this pull request May 24, 2024
Open
@V1CTORY360 V1CTORY360 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@ngochoangg ngochoangg mentioned this pull request May 24, 2024
Open
@jadsongmatos jadsongmatos mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
@RodolfoBorbon RodolfoBorbon mentioned this pull request May 24, 2024
Open
@SherfeyInv SherfeyInv mentioned this pull request May 25, 2024
Merged
@Avneesh-Rajput Avneesh-Rajput mentioned this pull request May 25, 2024
Open
@martinez-ml martinez-ml mentioned this pull request Sep 14, 2024
Merged
@GTVolk GTVolk mentioned this pull request Sep 14, 2024
Open
@Cpano Cpano mentioned this pull request Sep 17, 2024
Open
@GTVolk GTVolk mentioned this pull request Sep 17, 2024
Open
@Cpano Cpano mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 18, 2024
Open
Open
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
@pinco227 pinco227 mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 28, 2024
Open
Open
@lisagorewitdecker lisagorewitdecker mentioned this pull request Sep 30, 2024
Merged
This was referenced Sep 30, 2024
Open
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Merged
This was referenced Oct 12, 2024
Open
Open
Open
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees

No one assigned

Labels

docs v5

Projects

No open projects
v5.3.1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coliff @julien-deramond