Skip to content

Allow hidden="until-found" #42025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chefarbeiter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow hidden="until-found" #42025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scss/_reboot.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,8 +610,8 @@ progress {

// Hidden attribute
//
// Always hide an element with the `hidden` HTML attribute.
// Always hide an element with the `hidden` HTML attribute, unless until-found is used.

[hidden] {
[hidden]:not([hidden="until-found"]) {
display: none !important;
}
2 changes: 1 addition & 1 deletion site/src/content/docs/content/reboot.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ The default `cursor` on summary is `text`, so we reset that to `pointer` to conv

## HTML5 `[hidden]` attribute

HTML5 adds [a new global attribute named `[hidden]`](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden), which is styled as `display: none` by default. Borrowing an idea from [PureCSS](https://purecss.io/), we improve upon this default by making `[hidden] { display: none !important; }` to help prevent its `display` from getting accidentally overridden.
HTML5 adds [a new global attribute named `[hidden]`](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden), which is styled as `display: none` by default. Borrowing an idea from [PureCSS](https://purecss.io/), we improve upon this default by making `[hidden]:not([hidden="until-found"]) { display: none !important; }` to help prevent its `display` from getting accidentally overridden.

```html
<input type="text" hidden>
Expand Down