sway/auto_switch_kbd: new version (for contest)#4
Merged
hissssst merged 1 commit intotwmru:mainfrom May 10, 2021
Merged
Conversation
nacknime-official
force-pushed
the
main
branch
2 times, most recently
from
80c3d74 to
86319ec
Compare
Contributor
|
Could you please create separate script instead the modification of existing one? |
hissssst
reviewed
Dec 27, 2020
sway/auto_switch_kbd.py
Outdated
| from i3ipc import Connection, Event, events | ||
|
|
||
| KB_ID = "1:1:AT_Translated_Set_2_keyboard" | ||
| MAX_WIN_HISTORY = 15 |
Contributor
There was a problem hiding this comment.
It would be nice to have these parameters configurable via enviroment variables or script arguments
hissssst
reviewed
Dec 27, 2020
sway/auto_switch_kbd.py
Outdated
| if len(window_list) > MAX_WIN_HISTORY: | ||
| deleting_window_id = window_list.pop(-1) | ||
| del data[deleting_window_id] | ||
| print(window_list) |
Contributor
There was a problem hiding this comment.
Are these print() necessary?
Contributor
Author
There was a problem hiding this comment.
I'm sorry, I forgot to remove that line
Contributor
Author
Yes, but what name I can give to the file? |
nacknime-official
force-pushed
the
main
branch
2 times, most recently
from
83a1621 to
6043fab
Compare
Contributor
|
Any filename, for example |
nacknime-official
force-pushed
the
main
branch
from
6043fab to
6f86b42
Compare
Contributor
Author
Done |
nacknime-official
force-pushed
the
main
branch
from
6f86b42 to
e60f9a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.