Add RerunnableTimer and RerunnableClock implementations #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisbrown
approved these changes
Mar 16, 2020
Contributor
travisbrown
left a comment
travisbrown
left a comment
There was a problem hiding this comment.
Looks good to me! 👍 after format.
By the way feel free to relax -Yno-predef if you'd prefer. I like being made aware of implicit conversions, etc. in performance-sensitive code, but I think it's less useful now than it was a few years ago.
felixbr
force-pushed
the
rerunnable-timer
branch
from
db662a5 to
5378bfc
Compare
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 93.98% 92.95% -1.03%
==========================================
Files 5 7 +2
Lines 133 142 +9
Branches 3 3
==========================================
+ Hits 125 132 +7
- Misses 8 10 +2
Continue to review full report at Codecov.
|
Contributor
|
Feel free to merge when ready, @felixbr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
fs2often an instance ofcats.effect.Timer[F]is needed for delays, throttling and time-based buffering of streams.I added
RerunnableTimerand the transitive requirementRerunnableClockwhich help contruct such an instance easily.RerunnableClockis extremely close to the implementation incats-effectand the tests are mostly for coverage as the code is really quite simple.RerunnableTimeris based oncom.twitter.util.Timer, which makes things straightforward.