Skip to content

Conversation

@dangerousben
Copy link
Contributor

No description provided.

@dangerousben dangerousben force-pushed the feature/future-bracket-instance branch from f8adf07 to 36c2137 Compare July 2, 2020 18:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #237 into master will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   91.08%   91.30%   +0.22%     
==========================================
  Files           8        9       +1     
  Lines         157      161       +4     
  Branches        3        3              
==========================================
+ Hits          143      147       +4     
  Misses         14       14              
Impacted Files Coverage Δ
...scala/io/catbird/util/effect/FutureInstances.scala 100.00% <100.00%> (ø)
...a/io/catbird/util/effect/RerunnableInstances.scala 100.00% <100.00%> (ø)
...rc/main/scala/io/catbird/util/effect/package.scala 88.88% <100.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b4b17b...f5c03e2. Read the comment docs.

@dangerousben
Copy link
Contributor Author

Huh... the build was failing and I tweaked the travis config a bit (updating versions and fixing warnings), not expecting that to fix it, but now it passes. So possibly an intermittent failure lurking here.

@dangerousben dangerousben force-pushed the feature/future-bracket-instance branch from 36c2137 to f5c03e2 Compare July 2, 2020 18:25
@dangerousben
Copy link
Contributor Author

Huh... the build was failing and I tweaked the travis config a bit (updating versions and fixing warnings), not expecting that to fix it, but now it passes. So possibly an intermittent failure lurking here.

Scratch that, the failure was actually due to a scalafmt error, fixed now.

@travisbrown
Copy link
Contributor

@felixbr Any objection to merging this before a new release?

@felixbr
Copy link
Contributor

felixbr commented Jul 8, 2020

No, looks great! 👍

@travisbrown travisbrown merged commit 504edd2 into typelevel:master Jul 9, 2020
@dangerousben dangerousben deleted the feature/future-bracket-instance branch July 9, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants