Skip to content

Conversation

@dangerousben
Copy link
Contributor

So tiny as to be arguably pointless but I've found I needed it more
than once.

@dangerousben dangerousben force-pushed the feature/rerunnable-functionk branch from fe386ea to 300bbce Compare July 9, 2020 15:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2020

Codecov Report

Merging #240 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   91.30%   91.35%   +0.05%     
==========================================
  Files           9        9              
  Lines         161      162       +1     
  Branches        3        5       +2     
==========================================
+ Hits          147      148       +1     
  Misses         14       14              
Impacted Files Coverage Δ
...il/src/main/scala/io/catbird/util/Rerunnable.scala 90.36% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 504edd2...86a610e. Read the comment docs.

So tiny as to be arguably pointless but I've found I needed it more
than once.
@dangerousben dangerousben force-pushed the feature/rerunnable-functionk branch from 300bbce to 86a610e Compare July 10, 2020 01:20
@felixbr
Copy link
Contributor

felixbr commented Jul 10, 2020

Looks good to me.

I have no idea what the naming convention for FunctionK instances is. I feel like toFutureK would be clearer, so I'll let @travisbrown merge this one :)

@travisbrown
Copy link
Contributor

I like toFuture, especially given that in normal usage it's not clear that there's a FunctionK involved at all.

@travisbrown travisbrown merged commit 9658946 into typelevel:master Jul 10, 2020
@dangerousben dangerousben deleted the feature/rerunnable-functionk branch July 10, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants