Add docblocks for methoods that create instances that call Await. #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes a standard warning about Await and production code. Addresses typelevel#243.
dangerousben
force-pushed
the
feature/await-docs
branch
from
46f3609 to
2e63136
Compare
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 9 9
Lines 162 162
Branches 3 5 +2
=======================================
Hits 148 148
Misses 14 14
Continue to review full report at Codecov.
|
travisbrown
approved these changes
Jul 13, 2020
Contributor
travisbrown
left a comment
travisbrown
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Contributor
|
Very nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a standard warning about Await and production code.
Addresses #243.