Skip to content

Conversation

@danicheg
Copy link
Member

@danicheg danicheg commented Sep 7, 2021

Because finagle is not published for Scala 3 we are using the for3Use2_13 option.

.settings(
libraryDependencies += "com.twitter" %% "util-core" % utilVersion,
libraryDependencies +=
("com.twitter" %% "util-core" % utilVersion).cross(CrossVersion.for3Use2_13),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though util-core is published for Scala 3, finagle is dependent on it, so we were forced to use the for3Use2_13 option 🤷🏻‍♂️

@felixbr
Copy link
Contributor

felixbr commented Sep 8, 2021

I'm not sure we should publish an artifact using the for3Use2_13 option. It's not meant for libraries as it easily creates dependency hell if someone depends on other cats-libraries with proper Scala 3 support.

Instead you should depend on catbird using the for3Use2_13 option in your application if that's possible with twitter libraries.

edit: I'm not at all opposed to changes that will make a future Scala 3 port easier or ones that allow for3Use2_13 to work in applications

edit2: See also point 5 in Daniel Spiewak's guidelines on Scala 3 cross-publishing

@danicheg
Copy link
Member Author

danicheg commented Sep 8, 2021

@felixbr your position is reasonable. So that PR will be waiting for the release finagle on Scala 3, I'm ok with it.

@bpholt
Copy link
Member

bpholt commented Jun 7, 2022

I'm going to close this for now, but please feel free to reopen once Finagle supports Scala 3.

@bpholt bpholt closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants