Setup MiMa for finagle #430
Conversation
project/FinaglePlugin.scala
Outdated
| libraryDependencies += module, | ||
| mimaCurrentClassfiles := { | ||
| (Compile / dependencyClasspath).value.seq.map(_.data).find(_.getName.startsWith(module.name)).get | ||
| }, |
There was a problem hiding this comment.
A little hacky but seems to work :)
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 7 7
Lines 124 124
Branches 2 2
=======================================
Hits 112 112
Misses 12 12 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| import com.typesafe.tools.mima.plugin.SbtMima | ||
| import org.typelevel.sbt.NoPublishPlugin | ||
|
|
||
| object FinaglePlugin extends AutoPlugin { |
There was a problem hiding this comment.
For every finagle module you want to check bincompat of, this plugin creates a synthetic (no-publish) project for it in your build. Each of these projects is configured for MiMa, except we set mimaCurrentClassfiles to the current finagle dependency (rather than the project's compile output, which is irrelevant).
There was a problem hiding this comment.
Then, all of these projects are aggregated into rootFinagle.
|
This is pretty cool. Looking forward to trying it out for real when they update upstream—hopefully it will be able to tell us whether whatever version is next (I was expecting |
| lazy val finagleVersion = versions.head | ||
| } | ||
|
|
||
| /* When a new Finagle version is released, add it to the beginning of |
|
I tried setting |
3 participants
Give it a try with
rootFinagle/mimaReportBinaryIssues:)