Skip to content

Conversation

@mishriky
Copy link
Contributor

@mishriky mishriky commented May 5, 2022

No description provided.

@mishriky mishriky mentioned this pull request May 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #454 (2a0831f) into master (d005337) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   91.21%   91.21%           
=======================================
  Files          18       18           
  Lines         296      296           
  Branches        2        2           
=======================================
  Hits          270      270           
  Misses         26       26           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d005337...2a0831f. Read the comment docs.

@bpholt
Copy link
Member

bpholt commented May 5, 2022

Thanks! There were some changes made in 21.9.0 that may cause issues, so I'd like to look at those before we merge. (I'm away from my computer at the moment or I'd be more specific.)

Also, I think technically Twitter released 22.4.0, but there were no changes from 22.3.0. We may still want to go to that version to facilitate eventually having Scala Steward initiate these kinds of updates.

@mishriky
Copy link
Contributor Author

mishriky commented May 5, 2022

Thanks for the quick feedback. Changed to 22.4
Let me know if I can help with the 21.9.0 changes

@mishriky mishriky changed the title Update Finagle, Util to 22.3 Update Finagle, Util to 22.4 May 6, 2022
@mishriky
Copy link
Contributor Author

@bpholt curious if I can help with anything to get this change merged/released

@bpholt
Copy link
Member

bpholt commented May 31, 2022

I think it's ok to move forward with this, but we need to wait for (at least) #460 so that we can actually publish a new version of this library.

This is the change that was giving me pause before. It removed higher kinded types from the Finagle traits generated by Scrooge (and Finagle itself made it pretty difficult to reintroduce them, since it uses reflection with hardcoded trait names to start a Finagle server). We work around this at Dwolla by using the Scalafix rules in our async-utils library to rewrite the Scrooge-generated code to something that keeps the higher-kinded traits but is still compatible with Finagle.

@bpholt
Copy link
Member

bpholt commented May 31, 2022

Incorporated into #461.

@bpholt bpholt closed this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants