Allow magic CSL tests#418
Merged
Merged
Conversation
reknih
approved these changes
Nov 10, 2025
Member
reknih
left a comment
reknih
left a comment
There was a problem hiding this comment.
I thought that these are citeproc-js specific and don't contain behavior used in the spec. But since citeproc-js pretty much is the reference implementation, it is safe to assume that styles rely on these tests.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why these were not allowed before. If there is a good reason, I'm unaware.
Adds 40 tests. 24 pass. No clue how many are skipped.