Skip to content

Return error if adding a package fails.#73

Merged
hugelgupf merged 1 commit intou-root:mainfrom
Prabhuk:main
Jun 8, 2022
Merged

Return error if adding a package fails.#73
hugelgupf merged 1 commit intou-root:mainfrom
Prabhuk:main

Conversation

@Prabhuk
Copy link
Contributor

@Prabhuk Prabhuk commented Jun 6, 2022

Current behavior allows for the build to continue if adding a package fails. Modifying the behavior to fail fast to identify the build failures.

@10000TB
Copy link
Member

10000TB commented Jun 6, 2022

for the DCO failure, try run this git commit --amend --signoff and then force push, which include a sign off line in your commit message

10000TB
10000TB previously approved these changes Jun 6, 2022
Signed-off-by: Prabhu Rajasekaran <prabhukr@google.com>
@hugelgupf hugelgupf merged commit 36fb46b into u-root:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants