Remember temporarily whitelisted sites after updates

[cae3uax]

Prerequisites

• I verified that this is not a filter issue
  • Filter issues MUST be reported at filter issue tracker
• This is not a support issue or a question
  • Support issues and questions are handled at /r/uBlockOrigin
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
• I tried to reproduce the issue when...
  • uBlock Origin is the only extension
  • uBlock Origin with default lists/settings
  • using a new, unmodified browser profile
• I am running the latest version of uBlock Origin
• I checked the documentation to understand that the issue I report is not a normal behavior

Description

If dynamic filtering is used and uBlock Origin is updated while various sites are temporarily whitelisted, these sites are no longer temporarily whitelisted after the update. For long running browser sessions with many tabs open and multiple projects going on, this is quite annoying.

A fix is of course to disallow automatic updates under the uBlock Origin extension settings, but I will then probably forget about checking for updates manually and I like the updating to take care of itself.

I don't know if it can be done at all, but a nice enhancement is if uBlock Origin would not forget about the temporarily allowed stuff after an update.

Just to be clear, I temporarily allow some sites, because I don't want to permanently whitelist them. After the update, the sites should still just be temporarily whitelisted.

A specific URL where the issue occurs

https://www.google.com/

Steps to Reproduce

1. Enable dynamic filtering and temporarily whitelist a site.
2. Wait for uBlock Origin to update to a newer version.

Expected behavior:

uBlock Origin will still remember the temporarily whitelisted site after the update.

Actual behavior:

uBlock Origin does no longer remember the temporarily whitelisted site after the update.

Your environment

• uBlock Origin version: 1.22
• Browser Name and version: Mozilla Firefox 68.0.2

Probably implemented in Fx by this: https://bugzilla.mozilla.org/show_bug.cgi?id=1279012

[uBlock-user]

When any extension updates the browser reloads the extension entirely that's the same as closing and browser and opening again, so unsaved settings are lost. This is not an issue fyi.

[gorhill]

As pointed out by @gwarser, uBO can prevent the reload by registering a onUpdateAvailable() listener.

[uBlock-user]

Is that available for Chromium too ?

This was available in Chrome 25:

• https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/reload#Browser_compatibility
• https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/runtime/onUpdateAvailable#Browser_compatibility

No idea why I was watching this bug. And it is 3 years old ??? Fx 51? It seemed to me it was more recent.

I think this prevents downgrading. I need to disable uBO to downgrade.

Does not prevent update when checking manually (good?).

Will go back to b1 and wait for auto update.

Off topic (labels)

Side note: can we have rule to not set fixed label if not tested? Or maybe you tested this already @uBlock-user?

[gorhill]

I need to disable uBO to downgrade.

That's an unavoidable side effect, acceptable given that restarting uBO mid-session can cause loss of settings for majority of users. Those testing uBO will have to accept to deal with the manual reload step.

[gorhill]

I could force a reload if the version number is lower than the current version -- the assumption would be that cases of downgrading are always done manually and hence it's safe to reload the extension.

[uBlock-user]

@gwarser I couldn't test it because the commit is only added, there was no release. I couldn't even if I wanted to. Now coming to the point of adding the fixed label or not, you closed it, so I added the label believing you tested it. I didn't close it even though the commit was added 2 days ago because there was no updated release in the release section.