Update jQuery / Bootstrap, replace Fluid Infusion#660
Open
Naenyn wants to merge 12 commits intouPortal-Project:masterfrom
Open
Update jQuery / Bootstrap, replace Fluid Infusion#660Naenyn wants to merge 12 commits intouPortal-Project:masterfrom
Naenyn wants to merge 12 commits intouPortal-Project:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the notification portlet front-end by moving away from bundled legacy JS/CSS (older jQuery/Bootstrap + jQueryUI-style effects) toward portal-provided libraries and Bootstrap 5-compatible markup/JS.
Changes:
- Switch multiple JSP views from locally bundled jQuery to portal-provided jQuery/underscore patterns.
- Update Bootstrap modal/alert integrations to Bootstrap 5 APIs/attributes and remove jQueryUI-dependent animations.
- Migrate Job Postings from legacy DataTables API to DataTables 2-style initialization and filtering, plus Bootstrap 5 class updates.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| notification-portlet-webapp/src/main/webapp/WEB-INF/jsp/simple-list.jsp | Removes embedded jQuery include; uses portal/global jQuery reference. |
| notification-portlet-webapp/src/main/webapp/WEB-INF/jsp/show-alerts.jsp | Drops conditional library loading; updates paging logic to avoid jQueryUI effects; swaps notice script include. |
| notification-portlet-webapp/src/main/webapp/WEB-INF/jsp/modal.jsp | Updates Bootstrap modal markup for v5 and replaces hidden template class. |
| notification-portlet-webapp/src/main/webapp/WEB-INF/jsp/jobPostings.jsp | Updates markup/classes for Bootstrap 5 and removes CDN/inline library-loading logic. |
| notification-portlet-webapp/src/main/webapp/WEB-INF/jsp/icon.jsp | Removes conditional resource loading and standardizes on portal jQuery namespace. |
| notification-portlet-webapp/src/main/webapp/WEB-INF/jsp/accordion.jsp | Removes conditional resource loading and uses portal/global jQuery + underscore. |
| notification-portlet-webapp/src/main/webapp/scripts/modal-notice.js | Migrates modal show/hide/event wiring to Bootstrap 5 Modal API. |
| notification-portlet-webapp/src/main/webapp/scripts/jquery.notifications.js | Updates underscore templating calls and adjusts animations/Bootstrap dismiss attribute. |
| notification-portlet-webapp/src/main/webapp/scripts/job-postings.js | Migrates DataTables usage to DataTables 2 patterns and Bootstrap 5 modal usage; changes filtering logic. |
| notification-portlet-webapp/src/main/webapp/less/job-postings.less | Minor styling updates for Bootstrap 5 layout and list formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The usePortalJsLibs portlet preference was originally introduced to support deploying NotificationPortlet outside of uPortal, where no portal-provided jQuery would be available. Since this portlet depends on uPortal's Soffit for authentication, standalone deployment is not a supported use case. Remove usePortalJsLibs preference and all associated conditional logic: - Drop USE_PPORTAL_JS_LIBS_PREFERENCE constant and model attribute from NotificationIconController and EmergencyAlertController - Remove c:choose/noConflict fallback from icon.jsp and show-alerts.jsp - Remove conditional jQueryResources.xml include from icon.jsp - Remove usePortalJsLibs preference entries from portlet.xml - Update portalJsNamespace preference comments to remove references to the now-removed preference
Naenyn
force-pushed
the
update_jquery_bootstrap
branch
from
0177b4d to
3048bee
Compare
… untrack .java-version
ChristianMurphy
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.