Bump Rails from 7.1.x to 7.2.x by jefferya · Pull Request #840 · ualbertalib/library-cms

jefferya · 2025-08-14T15:50:59Z

Update GitHub Action Node version
Bump Rails from 7.1.x to 7.2.x; address Bump Rails 7.2 #552
- Depends on Add Config Gem as a replacement for deprecated secrets.yml #845 (deprecated secrets.yml removal)
- Updates related to 7.2
- Updates related to changing the config.load_defaults from 7.0 to 7.2 (ActiveRecord column serializer & Comfy)

jefferya · 2025-08-15T19:46:00Z

A quick set of todos before I transition to my other position mid August.

:

Continue reviewing changes in: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html
- worked through sections up to the Framework Defaults section:
- Worded through default changed in config/initializers/new_framework_defaults_7_2.rb
- I noticed that config.load_defaults was set to 7.0 and not 7.1. This caused at least one problem, should doublecheck others changes highlighted in https://github.com/rails/rails/blob/v7.1.5.2/railties/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults_7_1.rb.tt
⚠️ breaking change addressed in Add Config Gem as a replacement for deprecated secrets.yml #845

jefferya · 2025-10-07T15:10:27Z

Test successful. Needs to be merged with #845, once approved. Merging involves accepting the merge conflicts from the introduction of the Config Gem.

…lock. * todo: update config & code

* as part of https://guides.rubyonrails.org/upgrading_ruby_on_rails.html

* rubocop-capybara, rubocop-minitest, rubocop-performance, and rubocop-rails extension supports the new plugin system in rubocop 1.72

* site loads enabling: config/initializers/new_framework_defaults_7_2.rb: * adds to workaround current Rails 7.2 incompatibility in restarone/comfortable-mexican-sofa: Rails.application.config.active_record.default_column_serializer = YAML

* After running bin/rails app:update, staging.rb not changed therefore align with updated production.rb while retaining staging/production differences.

jefferya · 2025-10-07T19:07:48Z

.github/workflows/ci.yml

+      - name: Read Node version from .tool-versions
+        id: node_version
+        run: |
+          echo "node_version=$(grep nodejs .tool-versions | awk '{print $2}')" >> $GITHUB_OUTPUT
+
      - uses: actions/setup-node@v5
        with:
-          node-version: 18
+          node-version: ${{ steps.node_version.outputs.node_version }}


Inconsistency between ./tool-versions and what is defined in the GitHub action. This change aligns the two.

jefferya · 2025-10-07T19:09:29Z

.rubocop.yml

+  - standard
+plugins:
  - rubocop-capybara
  - rubocop-minitest
  - rubocop-performance
  - rubocop-rails
-  - standard



Silence a warning while running rubocop. rubocop-capybara, rubocop-minitest, rubocop-performance, and rubocop-rails extension supports the new plugin system in rubocop 1.72.

jefferya · 2025-10-07T19:11:54Z

bin/rubocop

 require "bundler/setup"

+# explicit rubocop config increases performance slightly while avoiding config confusion.
+ARGV.unshift("--config", File.expand_path("../.rubocop.yml", __dir__))


bin/rails app:update suggestion.

jefferya · 2025-10-07T19:17:49Z

config/environments/development.rb

  # it changes. This slows down response time but is perfect for development
  # since you don't have to restart the web server when you make code changes.
-  config.cache_classes = false
+  config.enable_reloading = true


Rails 7.2: can omit cache_classes = false because it's now implied when enable_reloading = true. Suggestion by bin/rails app:update.

jefferya · 2025-10-07T19:18:59Z

config/application.rb

+    # Rails.application.config.active_record.default_column_serializer = nil
+    # comfortable_mexican_sofa v3.5 https://github.com/restarone/comfortable-mexican-sofa.git
+    # not updated for Rails 7.1 to specify serialization method for the
+    # Comfy::Cms::Fragment and Comfy::Cms::Revision models
+    Rails.application.config.active_record.default_column_serializer = YAML


Flagging as a non-default setting due to lack of maintenance on the current fork of comfortable_mexican_sofa. YAML needs to be specifed or comfortable_mexican_sofa patched to specify a serialization method for Comfy::Cms::Fragment and Comfy::Cms::Revision models.

jefferya · 2025-10-07T19:22:29Z

config/environments/production.rb

+  config.logger = ActiveSupport::Logger.new($stdout)
+    .tap { |logger| logger.formatter = ::Logger::Formatter.new }
+    .then { |logger| ActiveSupport::TaggedLogging.new(logger) }



bin/rails app:update suggestion. The previous config.logger definition aligned with Jupiter and/or the default Rails generated version of this file. The rest of this file aligns with bin/rails app:update suggestions with past customizations layered ontop. Similar with other config/environments/{environment}.rb files.

jefferya · 2025-10-07T19:28:25Z

config/puma.rb

+threads_count = ENV.fetch("RAILS_MAX_THREADS", 5)
+threads threads_count, threads_count

-# Allow puma to be restarted by `rails restart` command.
+# Specifies the `port` that Puma will listen on to receive requests; default is 3000.
+port ENV.fetch("PORT", 3000)
+
+# Allow puma to be restarted by `bin/rails restart` command.
 plugin :tmp_restart
+
+# Specify the PID file. Defaults to tmp/pids/server.pid in development.
+# In other environments, only set the PID file if requested.
+pidfile ENV["PIDFILE"] if ENV["PIDFILE"]


bin/rails app:update suggested text and reordering. I reordered to hopefully make the next Rails update easier. The pidfile setting was added by bin/rails app:update. I'm not sure if needed.

jefferya · 2025-10-07T19:30:44Z

404.html, 406-unsupported-browser.html, 422.html, 500.html, icon.png, and icon.svg were added by the bin/rails app:update. Should these be kept?

…refore downgrade rack to 3.1.17 with security fixes. Fixes merge from main causing build failures

jefferya · 2025-10-08T18:02:59Z

Gemfile.lock

-      rack (>= 2.2.4)
+      rack (>= 2.2.4, < 3.2)


Notice the refined version set on actionpack for rack. This requires the downgrade of rack from 3.2.2 to 3.1.17 later on in Gemfile.lock. Both remain supported: https://github.com/rack/rack?tab=readme-ov-file#version-supported. Impact seems unnoticable.

…ependency; revert to v4.35.0

pgwillia

Just the comment about the potential duplication of error messages. Is there work to do there?

pgwillia · 2025-10-08T18:21:03Z

public/404.html

I didn't see why we have this, but there's routes, an ErrorController and views in our code

library-cms/config/routes.rb

Lines 8 to 10 in 77ccbb3

match "/404", to: "errors#file_not_found", via: :all

match "/422", to: "errors#unprocessable", via: :all

match "/500", to: "errors#internal_server_error", via: :all

https://github.com/ualbertalib/library-cms/tree/main/app/views/errors
Does this replace that?

I accidentally deleted my commit on this while untangling the dependency problems. Yes, I need to redo work from 3 weeks ago.

Thanks for flagging this. Looks better now.

Just for my understanding... Are we handling errors in a non-standard way?

Did my research. It's a standard way of having custom error pages

https://guides.rubyonrails.org/configuring.html#config-exceptions-app

library-cms/config/application.rb

Line 26 in f359b99

config.exceptions_app = routes

There are many blogs describing this approach. Here's one from 2024 https://www.dotruby.com/articles/how-to-create-a-custom-error-page-in-rails

* Pre-existing config/routes.rb routes with custom erb file handle the error pages; see https://github.com/ualbertalib/library-cms/blob/77ccbb358e9e44ff2e797ead3549f86dc01e9e2c/config/routes.rb#L8-L10

pgwillia

Looks good to me! 👍

pgwillia · 2025-10-30T17:30:08Z

public/404.html

Did my research. It's a standard way of having custom error pages

https://guides.rubyonrails.org/configuring.html#config-exceptions-app

library-cms/config/application.rb

Line 26 in f359b99

config.exceptions_app = routes

There are many blogs describing this approach. Here's one from 2024 https://www.dotruby.com/articles/how-to-create-a-custom-error-page-in-rails

jefferya mentioned this pull request Aug 15, 2025

Bump Rails 7.2 #552

Closed

jefferya changed the title ~~[WIP] Bump Rails from 7.1.x to 7.2.x~~ Bump Rails from 7.1.x to 7.2.x Oct 7, 2025

jefferya added 6 commits October 7, 2025 12:30

Update the GitHub Action Node version.

6be5114

Update Rails from 7.1.x to 7.2.x: step 1, update Gemfile and Gemfile.…

99ba177

…lock. * todo: update config & code

After running bin/rails app:update and reviewing conflicts.

84865fb

* as part of https://guides.rubyonrails.org/upgrading_ruby_on_rails.html

Rubocop offenses fixes plus warnings removal

e178fd5

* rubocop-capybara, rubocop-minitest, rubocop-performance, and rubocop-rails extension supports the new plugin system in rubocop 1.72

Update config.load_defaults from 7.0 to 7.2

3f45e4f

* site loads enabling: config/initializers/new_framework_defaults_7_2.rb: * adds to workaround current Rails 7.2 incompatibility in restarone/comfortable-mexican-sofa: Rails.application.config.active_record.default_column_serializer = YAML

Update config/environments/staging.rb to align with Rails 7.2

e36db20

* After running bin/rails app:update, staging.rb not changed therefore align with updated production.rb while retaining staging/production differences.

jefferya force-pushed the jefferya/rails_7.2 branch from 66d8b1b to e36db20 Compare October 7, 2025 18:42

jefferya commented Oct 7, 2025

View reviewed changes

jefferya and others added 2 commits October 8, 2025 11:31

Merge branch 'main' into jefferya/rails_7.2

c89fb71

ActionPack 7.2.2.2 requires rack <3.2 (ActionPack v7.1.x did not) the…

3bedddb

…refore downgrade rack to 3.1.17 with security fixes. Fixes merge from main causing build failures

jefferya commented Oct 8, 2025

View reviewed changes

jefferya and others added 3 commits October 8, 2025 16:10

Merge branch 'main' into jefferya/rails_7.2

57d7d12

Selenium-webdriver v4.36.0 not compatible with Rails v7.2.2.2; json d…

15dc630

…ependency; revert to v4.35.0

Merge remote-tracking branch 'origin/main' into jefferya/rails_7.2

ac89e19

pgwillia reviewed Oct 29, 2025

View reviewed changes

bin/rails app:update added HTTP error pages; remove duplication

f359b99

* Pre-existing config/routes.rb routes with custom erb file handle the error pages; see https://github.com/ualbertalib/library-cms/blob/77ccbb358e9e44ff2e797ead3549f86dc01e9e2c/config/routes.rb#L8-L10

pgwillia approved these changes Oct 30, 2025

View reviewed changes

jefferya merged commit d34aed4 into main Oct 30, 2025
2 checks passed

jefferya deleted the jefferya/rails_7.2 branch October 30, 2025 18:55

jefferya mentioned this pull request Oct 30, 2025

Bump Rails to v8 Investigation #880

Open

	match "/404", to: "errors#file_not_found", via: :all
	match "/422", to: "errors#unprocessable", via: :all
	match "/500", to: "errors#internal_server_error", via: :all

Conversation

jefferya commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jefferya commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jefferya commented Oct 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jefferya Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jefferya commented Oct 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pgwillia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pgwillia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jefferya commented Aug 14, 2025 •

edited

Loading

jefferya commented Aug 15, 2025 •

edited

Loading

jefferya Oct 7, 2025 •

edited

Loading