-
Notifications
You must be signed in to change notification settings - Fork 1
Update Rails to v8.1 #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jefferya
wants to merge
4
commits into
main
Choose a base branch
from
jefferya/880_rails_8.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Rails to v8.1 #884
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
af9a23a
Update from Rails 7.2.x to 8.0.x; address #880
jefferya ca7555f
Bump rails from 8.0 to 8.1; address #880
jefferya b10f72e
Remove duplicate in config and setup env fix.
jefferya e8d7efd
Rails 8.1 db:schema:dump: columns are now sorted alphabetically by name.
jefferya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #!/usr/bin/env ruby | ||
| require_relative "../config/boot" | ||
| require "active_support/continuous_integration" | ||
|
|
||
| CI = ActiveSupport::ContinuousIntegration | ||
| require_relative "../config/ci.rb" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ require "fileutils" | |
| APP_ROOT = File.expand_path("..", __dir__) | ||
|
|
||
| def system!(*args) | ||
| system(*args) || abort("\n== Command #{args} failed ==") | ||
| system(*args, exception: true) || abort("\n== Command #{args} failed ==") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I accepted suggestions by |
||
| end | ||
|
|
||
| FileUtils.chdir APP_ROOT do | ||
|
|
@@ -17,6 +17,11 @@ FileUtils.chdir APP_ROOT do | |
| system! "gem install bundler --conservative" | ||
| system("bundle check") || system!("bundle install") | ||
|
|
||
| # puts "\n== Copying sample files ==" | ||
| # unless File.exist?("config/database.yml") | ||
| # FileUtils.cp "config/database.yml.sample", "config/database.yml" | ||
| # end | ||
|
|
||
| puts "\n== Install JavaScript dependencies ==" | ||
| system("yarn check --check-files") || system!("yarn install") | ||
|
|
||
|
|
@@ -26,9 +31,15 @@ FileUtils.chdir APP_ROOT do | |
| puts "\n== Preparing database ==" | ||
| system! "bin/rails db:prepare" | ||
|
|
||
| system! "bin/rails db:reset" if ARGV.include?("--reset") | ||
|
|
||
| puts "\n== Removing old logs and tempfiles ==" | ||
| system! "bin/rails log:clear tmp:clear" | ||
|
|
||
| puts "\n== Restarting application server ==" | ||
| system! "bin/rails restart" | ||
| unless ARGV.include?("--skip-server") | ||
| puts "\n== Starting development server ==" | ||
| STDOUT.flush # flush the output before exec(2) so that it displays | ||
| #exec "bin/dev" | ||
| system! "bin/rails restart" | ||
| end | ||
| end | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New feature in Rails 8, this file is the default added by
rails app:update