Skip to content
This repository was archived by the owner on Sep 25, 2020. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/middleware/transport.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var transportServerMiddleware = {
callback(arg2, arg3);
},
'response': function(req, err, res1, res2, callback) {
if (res2 !== undefined && typeof res2 !== 'string') {
if (res2 !== undefined && typeof res2 !== 'string' && !Buffer.isBuffer(res2)) {
res2 = JSON.stringify(res2);
}
callback(err, res1, res2);
Expand Down
25 changes: 25 additions & 0 deletions test/integration/proxy_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -911,6 +911,31 @@ test('can serialize response body', function t(assert) {
});
});

test('proxies buffer responses', function t(assert) {
var cluster = allocCluster({
createHandler: function createHandler() {
return function handle(req, res) {
res.end(new Buffer('hello'));
};
}
}, function onReady() {
cluster.request({
host: 'one', key: cluster.keys.two
}, function onResponse(err, resp) {
assert.ifError(err);

assert.equal(resp.statusCode, 200);
assert.equal(
resp.body.toString('hex'),
new Buffer('hello').toString('hex')
);

cluster.destroy();
assert.end();
});
});
});

// new features
test('can handle errors differently');
test('adds forwarding header');
Expand Down
13 changes: 13 additions & 0 deletions test/unit/transport_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,16 @@ test('res2 is not JSON encoded if string', function t(assert) {
assert.equals(res2, 'string');
});
});

test('buffer-res2 is not JSON encoded if string', function t(assert) {
assert.plan(3);
var req = {};
var error = null;
var res1 = null;
var res2 = new Buffer('string');
transportMiddleware.response(req, error, res1, res2, function(err, res1, res2) {
assert.equals(err, null);
assert.equals(res1, null);
assert.deepEquals(res2, new Buffer('string'));
});
});