feat(payment-card): added uatp card support#4961
Merged
chasestarr merged 3 commits intouber:masterfrom May 24, 2022
Merged
Conversation
ayush712
requested review from
chasestarr,
lhbrennan,
tajo and
williamernest
as code owners
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3556f52:
|
Contributor
|
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: ayush712#1 |
Collaborator
|
LGTM, please review and merge in the new visual snapshot changes |
Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
chasestarr
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A new card type(UATP) support is added in this PR.
Created a custom card config array in custom-cards.config.js file,
So that in future if someone wants to add a new card type support,
he/she can add the configuration to custom-cards.config.js file itself.
He would not need to add the configuration in component file.
Because we support card icons as well so he would need to add a new icon
and add it to CardTypeToComponent variable.
A UATP card has a fixed length of 15 digits and its bin range lies between 1001 and 1999.
There is no CVV for UATP cards.
Scope
Minor: New Feature