fix(types): accordion, relax children type#5033
Merged
chasestarr merged 2 commits intouber:masterfrom Jul 15, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fe1589a:
|
zxbodya
commented
Jul 15, 2022
Comment on lines
-26
to
+37
| const key = child.key || String(index); | ||
| return React.cloneElement(child, { | ||
| disabled: child.props.disabled || disabled, | ||
| let normalizedChild = | ||
| typeof child === 'object' ? ( | ||
| (child as // skip {} from type definition | ||
| | React.ReactElement<any, string | React.JSXElementConstructor<any>> | ||
| | React.ReactPortal) | ||
| ) : ( | ||
| // if primitive value - wrap it in a fragment | ||
| <>{child}</> | ||
| ); | ||
| const key = normalizedChild.key || String(index); | ||
| return React.cloneElement(normalizedChild, { | ||
| disabled: normalizedChild.props.disabled || disabled, |
Contributor
Author
There was a problem hiding this comment.
as an option we can just ignore "unexpected elements", like this:
{React.Children.map(children, (child: React.ReactElement | React.ReactPortal, index) => {
if (!child.props) return;
chasestarr
approved these changes
Jul 15, 2022
| return React.cloneElement(child, { | ||
| disabled: child.props.disabled || disabled, | ||
| let normalizedChild = | ||
| typeof child === 'object' ? ( |
Collaborator
There was a problem hiding this comment.
Will ReactIs.isElement(child) handle the type cast?
Collaborator
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
yes, that would allow to remove typecast.
updated to use it, also added check for isPortal - that looks like another allowed case here
andriuss
pushed a commit
to andriuss/baseweb
that referenced
this pull request
Aug 2, 2022
* fix(types): accordion - relax children type * fix: use react-is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current type does not allow to pass children like this:
Making the type less strict (ReactNode instead of only ReactElement), also adding support for primitive values
Scope