fix(ts): mark default modal props as optional

[chasestarr]

Description

Seeing errors like below. I'm not sure why this kind of error does not raise when running tsc in baseui repo?

  | 2022-07-15 16:57:26 PDT | ....tsx:11:8 - error TS2740: Type '{ children: Element; onClose: () => any; isOpen: true; }' is missing the following properties from type 'ModalProps': animate, autoFocus, closeable, overrides, and 2 more.
  | 2022-07-15 16:57:35 PDT |  
  | 2022-07-15 16:57:35 PDT | 11       <Modal onClose={() => null} isOpen={true}>
  | 2022-07-15 16:57:35 PDT | ~~~~~
  | 2022-07-15 16:57:35 PDT |  
  | 2022-07-15 16:57:35 PDT | ....tsx:34:6 - error TS2740: Type '{ children: Element; onClose: () => void; isOpen: boolean; }' is missing the following properties from type 'ModalProps': animate, autoFocus, closeable, overrides, and 2 more.
  | 2022-07-15 16:57:35 PDT |  
  | 2022-07-15 16:57:35 PDT | 34     <Modal onClose={modalClose} isOpen={props.isOpen}>
  | 2022-07-15 16:57:35 PDT | ~~~~~

Scope

Patch: Bug Fix

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d7840e9:

Sandbox	Source
Basic usage	Configuration

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	65cf119
Status:	✅  Deploy successful!
Preview URL:	https://128e28db.baseweb.pages.dev
Branch Preview URL:	https://modal-optional-props.baseweb.pages.dev

View logs

[zxbodya]

I'm not sure why this kind of error does not raise when running tsc in baseui repo?

most likely the reason is that in code having the error Modal component is not used directly, but is wrapped in some kind of high order component

(when used directly like it is in baseui repository - typescript can see static defaultProps field on component, and so to treat properties provided there as optional)