Skip to content

fix(docs): add sharedProps to banner yard config#5046

Merged
lhbrennan merged 3 commits intomasterfrom
fix-banner-docs
Jul 19, 2022
Merged

fix(docs): add sharedProps to banner yard config#5046
lhbrennan merged 3 commits intomasterfrom
fix-banner-docs

Conversation

@lhbrennan
Copy link
Contributor

Description

The Banner page on the docs site was crashing when user clicks on the overrides tab and attempts to expand an override.

Scope

Patch: Bug Fix

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c71c7c:

Sandbox Source
Basic usage Configuration

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5c71c7c
Status: ✅  Deploy successful!
Preview URL: https://4d94f5d0.baseweb.pages.dev
Branch Preview URL: https://fix-banner-docs.baseweb.pages.dev

View logs

@lhbrennan lhbrennan marked this pull request as ready for review July 19, 2022 23:25
@lhbrennan lhbrennan requested a review from tajo as a code owner July 19, 2022 23:25
@lhbrennan lhbrennan merged commit 9455363 into master Jul 19, 2022
@lhbrennan lhbrennan deleted the fix-banner-docs branch July 19, 2022 23:42
andriuss pushed a commit to andriuss/baseweb that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants