chore(banner): export banner override types#5055
Merged
chasestarr merged 8 commits intouber:masterfrom Aug 11, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e8e6266:
|
chasestarr
reviewed
Jul 22, 2022
src/banner/types.js.flow
Outdated
| type?: ArtworkTypeT, | ||
| |}; | ||
|
|
||
| export type OverridesT = { |
Collaborator
There was a problem hiding this comment.
Can you please maintain the exact pipes? https://flow.org/en/docs/types/objects/#toc-exact-object-types
austingreco
force-pushed
the
agreco/banner-override-type
branch
from
05ec89c to
cc3dafb
Compare
austingreco
force-pushed
the
agreco/banner-override-type
branch
from
abcf54c to
39289a4
Compare
chasestarr
approved these changes
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When trying to add typing for banner overrides, I found the types not exported like other components:
Scope
Patch