Skip to content

fix(badge): update badge text colors#5125

Merged
lhbrennan merged 4 commits intomasterfrom
fix-badge-text-color-dark-mode
Aug 23, 2022
Merged

fix(badge): update badge text colors#5125
lhbrennan merged 4 commits intomasterfrom
fix-badge-text-color-dark-mode

Conversation

@lhbrennan
Copy link
Contributor

Description

Updating text colors for better contrast in dark mode:

  • warning (yellow) badges now use contentOnColorInverse
  • primary (black/white) badges continue to use contentInversePrimary
  • other colors now use contentOnColor

Scope

Patch: Bug Fix

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 23, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e873ced:

Sandbox Source
Basic usage Configuration

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 23, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e873ced
Status: ✅  Deploy successful!
Preview URL: https://48ce5038.baseweb.pages.dev
Branch Preview URL: https://fix-badge-text-color-dark-mo.baseweb.pages.dev

View logs

@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #5126

UberOpenSourceBot and others added 2 commits August 23, 2022 11:48
Co-authored-by: UberOpenSourceBot <UberOpenSourceBot@users.noreply.github.com>
@lhbrennan lhbrennan marked this pull request as ready for review August 23, 2022 18:48
@lhbrennan lhbrennan merged commit 26c99f9 into master Aug 23, 2022
@lhbrennan lhbrennan deleted the fix-badge-text-color-dark-mode branch August 23, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants