Skip to content

fix(data-table): resize columns after row data changes#5136

Merged
chasestarr merged 6 commits intomasterfrom
data-table-resize-after-data-invalidation
Aug 26, 2022
Merged

fix(data-table): resize columns after row data changes#5136
chasestarr merged 6 commits intomasterfrom
data-table-resize-after-data-invalidation

Conversation

@chasestarr
Copy link
Collaborator

Data-table was not re-measuring column widths after row data changes. This PR adds new story and snapshot test to confirm it works in the future

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 25, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 10aafe2:

Sandbox Source
Basic usage Configuration

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 25, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 10aafe2
Status: ✅  Deploy successful!
Preview URL: https://4a5d563a.baseweb.pages.dev
Branch Preview URL: https://data-table-resize-after-data.baseweb.pages.dev

View logs

@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: #5140

UberOpenSourceBot and others added 2 commits August 26, 2022 11:24
@chasestarr chasestarr merged commit cf7e35c into master Aug 26, 2022
@chasestarr chasestarr deleted the data-table-resize-after-data-invalidation branch August 26, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants