Skip to content

Fix breadcrumb alignment and color #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhbrennan merged 5 commits into from
Aug 29, 2022
Merged

Fix breadcrumb alignment and color #5143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec99446
chore(breadcrumbs): update font color
Aug 26, 2022
2b6d053
fix(breadcrumbs): vertically center separator
Aug 26, 2022
6b48dda
Merge branch 'master' into fix-breadcrumb-alignment-and-color
Aug 26, 2022
7cf2fd0
test(vrt): update visual snapshots for 6b48dda [skip ci] (#5144)
UberOpenSourceBot Aug 26, 2022
eb12cf3
Merge branch 'master' into fix-breadcrumb-alignment-and-color
Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/breadcrumbs/styled-components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ StyledListItem.displayName = 'StyledListItem';

export const StyledSeparator = styled('div', ({ $theme }) => {
return {
display: 'inline-block',
display: 'inline-flex',
alignItems: 'center',
color: $theme.colors.breadcrumbsSeparatorFill,
marginLeft: $theme.sizing.scale300,
marginRight: $theme.sizing.scale300,
Expand Down
2 changes: 1 addition & 1 deletion src/themes/dark-theme/color-component-tokens.js.flow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default (themePrimitives: ColorTokensT = colorTokens): ComponentColorToke
buttonDisabledSpinnerBackground: themePrimitives.mono400,

// Breadcrumbs
breadcrumbsText: themePrimitives.mono100,
breadcrumbsText: themePrimitives.white,
breadcrumbsSeparatorFill: themePrimitives.mono200,

// Datepicker
Expand Down
2 changes: 1 addition & 1 deletion src/themes/dark-theme/color-component-tokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export default (themePrimitives: ColorTokens = colorTokens): ComponentColorToken
buttonDisabledSpinnerBackground: themePrimitives.mono400,

// Breadcrumbs
breadcrumbsText: themePrimitives.mono100,
breadcrumbsText: themePrimitives.white,

breadcrumbsSeparatorFill: themePrimitives.mono200,

Expand Down
2 changes: 1 addition & 1 deletion src/themes/light-theme/color-component-tokens.js.flow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default (themePrimitives: ColorTokensT = colorTokens): ComponentColorToke
buttonDisabledSpinnerBackground: themePrimitives.mono400,

// Breadcrumbs
breadcrumbsText: themePrimitives.mono900,
breadcrumbsText: themePrimitives.black,
breadcrumbsSeparatorFill: themePrimitives.mono700,

// Datepicker
Expand Down
2 changes: 1 addition & 1 deletion src/themes/light-theme/color-component-tokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export default (themePrimitives: ColorTokens = colorTokens): ComponentColorToken
buttonDisabledSpinnerBackground: themePrimitives.mono400,

// Breadcrumbs
breadcrumbsText: themePrimitives.mono900,
breadcrumbsText: themePrimitives.black,

breadcrumbsSeparatorFill: themePrimitives.mono700,

Expand Down
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--breadcrumbs-dark-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--breadcrumbs-dark-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--breadcrumbs-desktop-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--breadcrumbs-desktop-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--breadcrumbs-mobile-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--breadcrumbs-mobile-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--icon-overrides-dark-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--icon-overrides-dark-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--icon-overrides-dark-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--icon-overrides-desktop-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--icon-overrides-desktop-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--icon-overrides-desktop-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--icon-overrides-mobile-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--icon-overrides-mobile-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--icon-overrides-mobile-webkit-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--trailing-dark-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--trailing-dark-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--trailing-desktop-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--trailing-desktop-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--trailing-mobile-chromium-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified vrt/tests.vrt.js-snapshots/breadcrumbs--trailing-mobile-firefox-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.