fix: popover should only appear if the trigger event is focus-visible#5150
Merged
chasestarr merged 3 commits intouber:masterfrom Aug 29, 2022
Merged
fix: popover should only appear if the trigger event is focus-visible#5150chasestarr merged 3 commits intouber:masterfrom
chasestarr merged 3 commits intouber:masterfrom
Conversation
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dfaac43:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Popover focus issue. Popover should only appear if the last event was focus-visible
Description
Right now
onFocus()of popover container doesn't check if the triggering event is focus-visible and hence callsthis.open()on every focus event. However this results in unexpected behaviour. One example as shown in the video below is of a button with tooltip, which opens a Modal on click. Here when the modal is closed using backdrop click or close button click the tooltip re-appears. Which should not happen.Before
popover_before.mov
Ideally the tooltip should not appear on any click event that closes the modal and returns focus to the button. Only when keyboard event closes modal and button gets focus-visible then only the tooltip should appear. The suggested fix provides this expected behaviour.
After
popover_after.mov
Scope
Patch: Bug Fix