Skip to content

fix: make optional side-navigation props optional again #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chasestarr merged 1 commit into from
Aug 31, 2022
Merged

fix: make optional side-navigation props optional again #5153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/side-navigation/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export type NavigationProps = {
Is called on the nav item render to test if the item is currently selected.
If returns true the item will be rendered as an active one
*/
activePredicate: ((item: Item, activeItemId: string) => boolean) | undefined | null;
activePredicate?: ((item: Item, activeItemId: string) => boolean) | null;
/** List of navigation items */
items: Item[];
/** Used as a performance optimization if many nav items are rendered. Function provided to
Expand All @@ -52,9 +52,9 @@ export type NavigationProps = {
/** onChange handler that is called when a nav item is selected */
onChange?: (a: { item: Item; event: Event | KeyboardEvent }) => unknown;
/** Overrides for the internal elements and components */
overrides: NavigationOverrides;
overrides?: NavigationOverrides;
/** Optional transform function that is called for each Item */
mapItem: ((item: Item) => Item) | undefined | null;
mapItem?: ((item: Item) => Item) | null;
};

export type Item = {
Expand Down