fix(types): fix definition of optional TS theme properties#5186
Merged
chasestarr merged 2 commits intouber:masterfrom Oct 4, 2022
Merged
fix(types): fix definition of optional TS theme properties#5186chasestarr merged 2 commits intouber:masterfrom
chasestarr merged 2 commits intouber:masterfrom
Conversation
alexgorbatchev
requested review from
chasestarr,
lhbrennan and
tajo
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5b7711c:
|
chasestarr
approved these changes
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A number of optional theme properties is currently not defined correctly in TypeScript and don't match flow types. Furthermore, they cause a very annoying issue of not being compatible with
styletronandcsstypebecause ofnull.It's possible to workaround this with
?? undefined, however making this change across large code base is not ideal (and shouldn't be necessary IMO)Scope
Patch: Bug Fix