Skip to content

Conversation

@luneo7
Copy link
Contributor

@luneo7 luneo7 commented Oct 15, 2024

Adds native image test to the test matrix.
In order to do native image testing had to bump JUnit 4 to 5.
Mainly run the openrewrite recipe:

mvn org.openrewrite.maven:rewrite-maven-plugin:5.42.2:run \
 -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-testing-frameworks:2.20.1 \
 -Drewrite.activeRecipes=org.openrewrite.java.testing.junit5.JUnit4to5Migration,org.openrewrite.java.testing.junit5.JUnit5BestPractices

And later added a @DisabledInNativeImage for TestBindingCompleteness since we don't need to run this is native image and there this one fails because H3Core.class is not registered for reflection and also doesn't need to be for the project to work correctly.

If something is wrong in native image, resources for example we will get a failure like:
image

Or if something is wrong with the jni config we will get a seg fault like:
image

If you want to test it locally you need to have GraalVM installed (SDKMan is a good tool to manage installed SDKs) and run mvn -Dnative verify that will build and use the generated jar to run the the tests against.
You should get a message stating:
image

@luneo7
Copy link
Contributor Author

luneo7 commented Oct 15, 2024

/cc @isaacbrodsky @dfellis

assertEquals(ij1, ij3);
assertEquals(ij1, ij1);
assertNotEquals(ij1, null);
assertNotEquals(null, ij1);
Copy link
Collaborator

@isaacbrodsky isaacbrodsky Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the script proposed a no-op change here?

Copy link
Contributor Author

@luneo7 luneo7 Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is because of the method signature, the parameters are (unexpected, actual) so the unexpected is null, mainly semantics.
image

@coveralls
Copy link

coveralls commented Oct 15, 2024

Pull Request Test Coverage Report for Build #440

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.817%

Totals Coverage Status
Change from base Build #437: 0.0%
Covered Lines: 501
Relevant Lines: 507

💛 - Coveralls

@luneo7
Copy link
Contributor Author

luneo7 commented Oct 15, 2024

@isaacbrodsky if you can kick the tests again, added OCI_EXE so it doesn't use docker in one run and podman in other run, this was making the image pull fail sometimes

@isaacbrodsky isaacbrodsky merged commit f131c70 into uber:master Oct 15, 2024
@luneo7
Copy link
Contributor Author

luneo7 commented Oct 30, 2024

@isaacbrodsky is there any plan to have a release soon?

@isaacbrodsky
Copy link
Collaborator

soon

I hope to have a new release soon but unfortunately other obligations have taken some time. Thanks for your contributions and your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants