-
Notifications
You must be signed in to change notification settings - Fork 61
Add native image tests #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| assertEquals(ij1, ij3); | ||
| assertEquals(ij1, ij1); | ||
| assertNotEquals(ij1, null); | ||
| assertNotEquals(null, ij1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the script proposed a no-op change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Test Coverage Report for Build #440Details
💛 - Coveralls |
|
@isaacbrodsky if you can kick the tests again, added |
|
@isaacbrodsky is there any plan to have a release soon? |
I hope to have a new release soon but unfortunately other obligations have taken some time. Thanks for your contributions and your patience. |

Adds native image test to the test matrix.
In order to do native image testing had to bump JUnit 4 to 5.
Mainly run the openrewrite recipe:
And later added a
@DisabledInNativeImageforTestBindingCompletenesssince we don't need to run this is native image and there this one fails becauseH3Core.classis not registered for reflection and also doesn't need to be for the project to work correctly.If something is wrong in native image, resources for example we will get a failure like:

Or if something is wrong with the jni config we will get a seg fault like:

If you want to test it locally you need to have GraalVM installed (SDKMan is a good tool to manage installed SDKs) and run

mvn -Dnative verifythat will build and use the generated jar to run the the tests against.You should get a message stating: