Skip to content

polygonToCellsExperimental reorder flag, res arguments #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaacbrodsky merged 1 commit into from
Apr 27, 2025
Merged

polygonToCellsExperimental reorder flag, res arguments #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/com/uber/h3core/H3Core.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,8 @@ public List<Long> gridPathCells(long start, long end) {
* @param res Resolution of the desired indexes
*/
public List<String> polygonToCellAddressesExperimental(
List<LatLng> points, List<List<LatLng>> holes, PolygonToCellsFlags flags, int res) {
return h3ToStringList(polygonToCellsExperimental(points, holes, flags, res));
List<LatLng> points, List<List<LatLng>> holes, int res, PolygonToCellsFlags flags) {
return h3ToStringList(polygonToCellsExperimental(points, holes, res, flags));
}

/**
Expand All @@ -538,7 +538,7 @@ public List<String> polygonToCellAddressesExperimental(
* @throws IllegalArgumentException Invalid resolution
*/
public List<Long> polygonToCellsExperimental(
List<LatLng> points, List<List<LatLng>> holes, PolygonToCellsFlags flags, int res) {
List<LatLng> points, List<List<LatLng>> holes, int res, PolygonToCellsFlags flags) {
checkResolution(res);

// pack the data for use by the polyfill JNI call
Expand Down
20 changes: 10 additions & 10 deletions src/test/java/com/uber/h3core/TestRegion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ void polyfillExperimentalCenter() {
new LatLng(37.7835871999971715, -122.5247187000021967),
new LatLng(37.8151571999998453, -122.4798767000009008)),
null,
PolygonToCellsFlags.containment_center,
9);
9,
PolygonToCellsFlags.containment_center);

assertTrue(hexagons.size() > 1000);
}
Expand All @@ -59,8 +59,8 @@ void polyfillExperimentalFull() {
new LatLng(37.7835871999971715, -122.5247187000021967),
new LatLng(37.8151571999998453, -122.4798767000009008)),
null,
PolygonToCellsFlags.containment_full,
9);
9,
PolygonToCellsFlags.containment_full);

assertTrue(hexagons.size() > 1000);
}
Expand All @@ -77,8 +77,8 @@ void polyfillExperimentalOverlapping() {
new LatLng(37.7835871999971715, -122.5247187000021967),
new LatLng(37.8151571999998453, -122.4798767000009008)),
null,
PolygonToCellsFlags.containment_overlapping,
9);
9,
PolygonToCellsFlags.containment_overlapping);

assertTrue(hexagons.size() > 1000);
}
Expand All @@ -95,8 +95,8 @@ void polyfillExperimentalOverlappingBbox() {
new LatLng(37.7835871999971715, -122.5247187000021967),
new LatLng(37.8151571999998453, -122.4798767000009008)),
null,
PolygonToCellsFlags.containment_overlapping_bbox,
9);
9,
PolygonToCellsFlags.containment_overlapping_bbox);

assertTrue(hexagons.size() > 1000);
}
Expand All @@ -113,8 +113,8 @@ void polyfillExperimental() {
new LatLng(37.7835871999971715, -122.5247187000021967),
new LatLng(37.8151571999998453, -122.4798767000009008)),
null,
PolygonToCellsFlags.containment_center,
9);
9,
PolygonToCellsFlags.containment_center);

assertTrue(hexagons.size() > 1000);
}
Expand Down