Skip to content

fix (docs): reverse documentation for callVariant#946

Merged
zhuchcn merged 1 commit intomainfrom
czhu-reverse-docs
Oct 31, 2025
Merged

fix (docs): reverse documentation for callVariant#946
zhuchcn merged 1 commit intomainfrom
czhu-reverse-docs

Conversation

@zhuchcn
Copy link
Contributor

@zhuchcn zhuchcn commented Oct 31, 2025

Description

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

Copilot AI review requested due to automatic review settings October 31, 2025 08:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the module-level docstring for callVariant CLI to provide comprehensive documentation about its functionality. The brief one-line description has been replaced with a detailed multi-paragraph explanation of how callVariant processes GVF files and generates variant peptides.

Key Changes

  • Expanded the module docstring from a single line to a detailed 10-line description explaining the core algorithm and workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

INDEL, fusion, alternative splicing, RNA editing, and circRNA). The transcript
variant graph is then translated into a peptide variant graph, followed by
converting to a cleavage graph based on the enzymatic cleavage rule. The
variant peptide graph is than used to call for variant peptides that contains
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'than' to 'then' - should be 'then' when referring to sequence of events.

Suggested change
variant peptide graph is than used to call for variant peptides that contains
variant peptide graph is then used to call for variant peptides that contains

Copilot uses AI. Check for mistakes.
INDEL, fusion, alternative splicing, RNA editing, and circRNA). The transcript
variant graph is then translated into a peptide variant graph, followed by
converting to a cleavage graph based on the enzymatic cleavage rule. The
variant peptide graph is than used to call for variant peptides that contains
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar error: 'contains' should be 'contain' to agree with the plural subject 'peptides'.

Suggested change
variant peptide graph is than used to call for variant peptides that contains
variant peptide graph is than used to call for variant peptides that contain

Copilot uses AI. Check for mistakes.
variant graph is then translated into a peptide variant graph, followed by
converting to a cleavage graph based on the enzymatic cleavage rule. The
variant peptide graph is than used to call for variant peptides that contains
at least one variant, and do not present in the canonical peptide pool.
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar error: 'present' should be 'are present' or change to 'and are not present' for correct verb form.

Suggested change
at least one variant, and do not present in the canonical peptide pool.
at least one variant, and are not present in the canonical peptide pool.

Copilot uses AI. Check for mistakes.
@zhuchcn zhuchcn merged commit 7c71e46 into main Oct 31, 2025
13 checks passed
@zhuchcn zhuchcn deleted the czhu-reverse-docs branch October 31, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants